Repository navigation
Stop using private browsing - #339
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the cookie keywords to work with the default Firefox profile.
Now testing that app sees cookies set by Selenium and Selenium sees cookies set by app (both failed before the profile update in this PR). Remove server sending cookies that is no longer needed since the previous revision of the suite.
A lot of the effects of private browsing happen anyways because Selenium creates a temporary profile at session start.
Private browsing was enabled in a commit to stop Firefox from opening two browser windows, and this change does not cause a regression on my system. I wonder if @yanne remembers why this specific setting was made (many preferences changed in the commit).
Commit that enabled private browsing and related issue
Fixes #177